Add typed DB entities based on PHP reflection#35767
Closed
ChristophWurst wants to merge 2 commits intomasterfrom
Closed
Add typed DB entities based on PHP reflection#35767ChristophWurst wants to merge 2 commits intomasterfrom
ChristophWurst wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
…tion Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
| continue; | ||
| } | ||
|
|
||
| $this->addType($property->getName(), $propertyType->getName()); |
Check failure
Code scanning / Psalm
UndefinedMethod
| } | ||
|
|
||
| $this->addType($property->getName(), $propertyType->getName()); | ||
| self::$reflectedFieldTypes[$class][$property->getName()] = $propertyType->getName(); |
Check failure
Code scanning / Psalm
UndefinedMethod
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: n/a
Summary
Right now columns of a type other than string need to be refined using
Entity::addType, typically from the Entity constructor. We can derive this information from typed properties in PHP7.4+ and the help of reflection.Combined with constructor property promostion in PHP8.0+ entities can be as simple as
While having PHPs full type support and automatic database type conversion.
The reason why I haven't added this feature into the existing
Entityis that it has to be done in the constructor and Entity has none. https://en.wikipedia.org/wiki/Fragile_base_classTODO
TypedEntityChecklist